Re: [tor-bugs] #32764 [Core Tor/Tor]: Solve code issues that block running clang-format on our code.

["Tor Bug Tracker & Wiki" <blackhole@xxxxxxxxxxxxxx>]

#32764: Solve code issues that block running clang-format on our code.
--------------------------+------------------------------------
 Reporter:  nickm         |          Owner:  nickm
     Type:  defect        |         Status:  merge_ready
 Priority:  Medium        |      Milestone:  Tor: 0.4.3.x-final
Component:  Core Tor/Tor  |        Version:
 Severity:  Normal        |     Resolution:
 Keywords:                |  Actual Points:  1
Parent ID:  #29226        |         Points:  1
 Reviewer:  teor          |        Sponsor:
--------------------------+------------------------------------
Changes (by teor):

 * status:  needs_review => merge_ready


Comment:

 These changes seem fine to me.
 GitHub is showing some conflicts, I'm happy for the merger to fix them up
 when they merge,

 The following inline header functions depend on some members of
 or_options_t, which is a dependency we don't need:
 * options_validate_dirauth_mode()
 * options_validate_server_transport()
 * options_validate_relay_mode()
 And the dependency only exists when the relay or dirauth modules are
 disabled.

 So I'd like to open another ticket to remove that dependency.
 (We could add stub C files that are only compiled when relay/dirauth mode
 is disabled.)

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/32764#comment:13>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online

_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs