[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

[tor-bugs] Re: #1245 [Tor - Tor client]: circuit_build_times_add_time: Assertion time <= BUILD_TIME_MAX failed



#1245: circuit_build_times_add_time: Assertion time <= BUILD_TIME_MAX failed
-------------------------------+--------------------------------------------
  Reporter:  arma              |       Owner:  mikeperry    
      Type:  defect            |      Status:  closed       
  Priority:  major             |   Milestone:  0.2.2.x-final
 Component:  Tor - Tor client  |     Version:  0.2.2.7-alpha
Resolution:  fixed             |    Keywords:               
    Parent:                    |  
-------------------------------+--------------------------------------------
Changes (by mikeperry):

  * status:  new => closed
  * resolution:  None => fixed


Old description:

> Feb 09 09:31:15.047 [Notice] Your system clock just jumped 26715 seconds
> forward; assuming established circuits no longer work.
> Feb 09 09:31:13.982 [Error] circuit_build_times_add_time(): Bug:
> circuitbuild.c:191: circuit_build_times_add_time: Assertion time <=
> BUILD_TIME_MAX failed; aborting.
>
> I hibernated my laptop last night, and when I turned it back on, Tor
> I guess was in the middle of building a circuit. It decided to time it
> out, since it had been building all night (while the machine was off).
>
> #0  0xb7f09424 in __kernel_vsyscall ()
> #1  0xb7bb0640 in raise () from /lib/i686/cmov/libc.so.6
> #2  0xb7bb2018 in abort () from /lib/i686/cmov/libc.so.6
> #3  0x0809b6a9 in circuit_build_times_add_time (cbt=0x815b100,
> time=4294966199)
>     at circuitbuild.c:191
> #4  0x0809f1a7 in circuit_send_next_onion_skin (circ=0x89f4b60)
>     at circuitbuild.c:1493
> #5  0x08061b8c in connection_edge_process_relay_cell (cell=0xbfe02a98,
>     circ=0x89f4b60, conn=0x0, layer_hint=0x87ee400) at relay.c:1159
> #6  0x08062879 in circuit_receive_relay_cell (cell=0xbfe02a98,
> circ=0x89f4b60,
>     cell_direction=CELL_DIRECTION_IN) at relay.c:200
> #7  0x080aba46 in command_process_cell (cell=0xbfe02a98, conn=0x884fe58)
>     at command.c:417
> #8  0x080c98f1 in connection_or_process_cells_from_inbuf (conn=0x884fe58)
>     at connection_or.c:1247
> #9  0x080ba62c in connection_process_inbuf (conn=0x884fe58,
> package_partial=6)
>     at connection.c:3181
> #10 0x080bf0b1 in connection_handle_read (conn=0x884fe58) at
> connection.c:2370
> #11 0x08052980 in conn_read_callback (fd=15, event=2, _conn=0x884fe58)
>     at main.c:479
> #12 0xb7e9d9e2 in event_base_loop () from /usr/lib/libevent-1.3e.so.1
> #13 0x080524ba in do_main_loop () at main.c:1512
> #14 0x08052795 in tor_main (argc=9, argv=0xbfe030d4) at main.c:2137
>
> #3  0x0809b6a9 in circuit_build_times_add_time (cbt=0x815b100,
> time=4294966199)
>     at circuitbuild.c:191
> 191       tor_assert(time <= BUILD_TIME_MAX);
> (gdb) print time
> $1 = 4294966199
> (gdb) up
> #4  0x0809f1a7 in circuit_send_next_onion_skin (circ=0x89f4b60)
>     at circuitbuild.c:1493
> 1493            circuit_build_times_add_time(&circ_times,
> (build_time_t)timediff);
> (gdb) print timediff
> $2 = 0
> (gdb) up
> #5  0x08061b8c in connection_edge_process_relay_cell (cell=0xbfe02a98,
>     circ=0x89f4b60, conn=0x0, layer_hint=0x87ee400) at relay.c:1159
> 1159          if
> ((reason=circuit_send_next_onion_skin(TO_ORIGIN_CIRCUIT(circ)))<0) {
> (gdb) print *circ
> $3 = {magic = 892424771, n_conn_cells = {head = 0x0, tail = 0x0, n = 0,
>     insertion_times = 0x0}, n_conn = 0x884fe58, n_circ_id = 47247,
>   n_hop = 0x0, streams_blocked_on_n_conn = 0, streams_blocked_on_p_conn =
> 0,
>   state = 3 '\003', purpose = 5 '\005', package_window = 1000,
>   deliver_window = 1000, n_conn_onionskin = 0x0,
>   timestamp_created = 1265725875, timestamp_dirty = 0, highres_created =
> {
>     tv_sec = 1265725875, tv_usec = 58412}, marked_for_close = 0,
>   marked_for_close_file = 0x0, next_active_on_n_conn = 0x0,
>   prev_active_on_n_conn = 0x0, next = 0x8b4c290, dirreq_id = 0,
> n_cell_ewma = {
>     last_adjusted_tick = 126572587, cell_count = 0, is_for_p_conn = 0,
>     heap_index = -1}}
>

>
> [Automatically added by flyspray2trac: Operating System: All]

New description:

 Feb 09 09:31:15.047 [Notice] Your system clock just jumped 26715 seconds
 forward; assuming established circuits no longer work.
 Feb 09 09:31:13.982 [Error] circuit_build_times_add_time(): Bug:
 circuitbuild.c:191: circuit_build_times_add_time: Assertion time <=
 BUILD_TIME_MAX failed; aborting.

 I hibernated my laptop last night, and when I turned it back on, Tor
 I guess was in the middle of building a circuit. It decided to time it
 out, since it had been building all night (while the machine was off).

 #0  0xb7f09424 in __kernel_vsyscall ()
 #1  0xb7bb0640 in raise () from /lib/i686/cmov/libc.so.6
 #2  0xb7bb2018 in abort () from /lib/i686/cmov/libc.so.6
 #3  0x0809b6a9 in circuit_build_times_add_time (cbt=0x815b100,
 time=4294966199)
     at circuitbuild.c:191
 #4  0x0809f1a7 in circuit_send_next_onion_skin (circ=0x89f4b60)
     at circuitbuild.c:1493
 #5  0x08061b8c in connection_edge_process_relay_cell (cell=0xbfe02a98,
     circ=0x89f4b60, conn=0x0, layer_hint=0x87ee400) at relay.c:1159
 #6  0x08062879 in circuit_receive_relay_cell (cell=0xbfe02a98,
 circ=0x89f4b60,
     cell_direction=CELL_DIRECTION_IN) at relay.c:200
 #7  0x080aba46 in command_process_cell (cell=0xbfe02a98, conn=0x884fe58)
     at command.c:417
 #8  0x080c98f1 in connection_or_process_cells_from_inbuf (conn=0x884fe58)
     at connection_or.c:1247
 #9  0x080ba62c in connection_process_inbuf (conn=0x884fe58,
 package_partial=6)
     at connection.c:3181
 #10 0x080bf0b1 in connection_handle_read (conn=0x884fe58) at
 connection.c:2370
 #11 0x08052980 in conn_read_callback (fd=15, event=2, _conn=0x884fe58)
     at main.c:479
 #12 0xb7e9d9e2 in event_base_loop () from /usr/lib/libevent-1.3e.so.1
 #13 0x080524ba in do_main_loop () at main.c:1512
 #14 0x08052795 in tor_main (argc=9, argv=0xbfe030d4) at main.c:2137

 #3  0x0809b6a9 in circuit_build_times_add_time (cbt=0x815b100,
 time=4294966199)
     at circuitbuild.c:191
 191       tor_assert(time <= BUILD_TIME_MAX);
 (gdb) print time
 $1 = 4294966199
 (gdb) up
 #4  0x0809f1a7 in circuit_send_next_onion_skin (circ=0x89f4b60)
     at circuitbuild.c:1493
 1493            circuit_build_times_add_time(&circ_times,
 (build_time_t)timediff);
 (gdb) print timediff
 $2 = 0
 (gdb) up
 #5  0x08061b8c in connection_edge_process_relay_cell (cell=0xbfe02a98,
     circ=0x89f4b60, conn=0x0, layer_hint=0x87ee400) at relay.c:1159
 1159          if
 ((reason=circuit_send_next_onion_skin(TO_ORIGIN_CIRCUIT(circ)))<0) {
 (gdb) print *circ
 $3 = {magic = 892424771, n_conn_cells = {head = 0x0, tail = 0x0, n = 0,
     insertion_times = 0x0}, n_conn = 0x884fe58, n_circ_id = 47247,
   n_hop = 0x0, streams_blocked_on_n_conn = 0, streams_blocked_on_p_conn =
 0,
   state = 3 '\003', purpose = 5 '\005', package_window = 1000,
   deliver_window = 1000, n_conn_onionskin = 0x0,
   timestamp_created = 1265725875, timestamp_dirty = 0, highres_created = {
     tv_sec = 1265725875, tv_usec = 58412}, marked_for_close = 0,
   marked_for_close_file = 0x0, next_active_on_n_conn = 0x0,
   prev_active_on_n_conn = 0x0, next = 0x8b4c290, dirreq_id = 0,
 n_cell_ewma = {
     last_adjusted_tick = 126572587, cell_count = 0, is_for_p_conn = 0,
     heap_index = -1}}



 [Automatically added by flyspray2trac: Operating System: All]

--

Comment:

 Fix should appear in 0.2.2.14.

-- 
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/1245#comment:4>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online