[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]
Re: [tor-bugs] #3472 [Tor Bridge]: Implementing the pluggable-transport spec (managed proxies)
#3472: Implementing the pluggable-transport spec (managed proxies)
------------------------+---------------------------------------------------
Reporter: asn | Owner: asn
Type: task | Status: new
Priority: normal | Milestone: Tor: 0.2.3.x-final
Component: Tor Bridge | Version:
Keywords: | Parent: #3591
Points: | Actualpoints:
------------------------+---------------------------------------------------
Comment(by nickm):
The filenames "pluggable_transports.[ch]" are pretty long. Can we just
have that be "transports.[ch]"
The argument-parsing code in parse_client_transport_line is O(N^2).
That's ugly. Also, instead of having it launch the transports, it should
probably just populate a data structure; there should be a separate
function to launch the transports. (Rationale: it's easier to test the
parsing.)
Also, what is the point of "x = tor_strdup(foo); tor_free(foo);" ? Why
not just "x = foo;" ?
In 810a7a5fa09734, the ST_prefix is too overloaded. Also, can the other
code that uses tor_spawn_background be made to use your read-a-line
function? It's best if we can avoid duplicated code there.
I'll look more at the actual code later.
--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/3472#comment:4>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs