[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

Re: [tor-bugs] #6400 [Tor Client]: Eliminate long SMARTLIST_FOREACH statements

#6400: Eliminate long SMARTLIST_FOREACH statements
-------------------------+--------------------------------------------------
 Reporter:  nickm        |          Owner:                    
     Type:  enhancement  |         Status:  needs_review      
 Priority:  normal       |      Milestone:  Tor: 0.2.4.x-final
Component:  Tor Client   |        Version:                    
 Keywords:               |         Parent:                    
   Points:               |   Actualpoints:                    
-------------------------+--------------------------------------------------

Comment(by arma):

 s/nexted/nested/

 In the changes file when you say "Do not allow", does anything enforce it
 in an ongoing way? If no, it's misleading.

 Would be great if the changes file referenced this bug number.

 The SMARTLIST_FOREACH() definition should have a comment telling you when
 it's inappropriate to use it.

 The code changes look good.

 I wouldn't oppose putting this patch into maint-0.2.3, on the "if we later
 want to backport a bugfix on any of the changed lines, it will make the
 backport cleaner" theory.

-- 
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/6400#comment:3>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs