Re: [tor-bugs] #16540 [Onionoo]: Close the the updater's shared HttpUrlConnection socket if an exception occurs.

["Tor Bug Tracker & Wiki" <blackhole@xxxxxxxxxxxxxx>]

#16540: Close the the updater's shared HttpUrlConnection socket if an exception
occurs.
-------------------------+----------------------------
     Reporter:  leeroy   |      Owner:  karsten
         Type:  defect   |     Status:  needs_revision
     Priority:  normal   |  Milestone:
    Component:  Onionoo  |    Version:
   Resolution:           |   Keywords:
Actual Points:           |  Parent ID:
       Points:           |
-------------------------+----------------------------
Changes (by karsten):

 * status:  needs_review => needs_revision


Comment:

 Ah, I'd rather want to give up on the stats and instead use metrics-lib's
 interface.  Extending metrics-lib's impl classes is something we shouldn't
 start doing.

 To give you some more context, the metrics-lib code to fetch descriptors
 from CollecTor was written first and then re-implemented slightly more
 generally in metrics-lib.  The earlier Onionoo code is not required
 anymore.  In theory, the Onionoo change here should remove many lines and
 only add very few new ones.  If this means leaving out stats log messages
 for now, I'm fine with that.

 In the future we could even have metrics-lib log these stats itself to a
 logger that Onionoo includes in its log files.  (That would be another
 ticket.)

 Hope that makes sense!

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/16540#comment:8>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs