[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

Re: [tor-bugs] #16424 [metrics-lib]: Add code to eventually support .xz compressed tarballs



#16424: Add code to eventually support .xz compressed tarballs
-----------------------------+--------------------------
     Reporter:  karsten      |      Owner:  karsten
         Type:  enhancement  |     Status:  needs_review
     Priority:  normal       |  Milestone:
    Component:  metrics-lib  |    Version:
   Resolution:               |   Keywords:
Actual Points:               |  Parent ID:  #16614
       Points:               |
-----------------------------+--------------------------

Comment (by karsten):

 Your last patches change things back that I fixed before, e.g., you again
 changed `entrySize` back to `entry_sz` which does not conform with the
 code style in metrics-lib or even Java in general.  Please trim your
 patches to the smallest size conceivable to facilitate the review process.
 And please push your branch to a public Git repository somewhere.
 Otherwise I'm inclined to squash and merge as is and address your concerns
 later or in different tickets.  In that case, if you're uneasy to have
 your name and email address as the author of that squashed Git commit, let
 me know and I'll change the author and credit you in the commit message
 instead.  Thanks.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/16424#comment:36>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs