[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

Re: [tor-bugs] #19554 [Core Tor/Tor]: Require libevent >= 2



#19554: Require libevent >= 2
--------------------------+------------------------------------
 Reporter:  Sebastian     |          Owner:
     Type:  defect        |         Status:  needs_review
 Priority:  Medium        |      Milestone:  Tor: 0.3.0.x-final
Component:  Core Tor/Tor  |        Version:
 Severity:  Normal        |     Resolution:
 Keywords:                |  Actual Points:
Parent ID:                |         Points:
 Reviewer:                |        Sponsor:
--------------------------+------------------------------------

Comment (by cypherpunks):

 A review after some quick grepping and reading relevant header files.

 src/common/compat_libevent.h
 - Remove the `le_version_t` typedef because it's unused now.
 - Update the following preprocessor function comment accordingly.

 src/common/compat_libevent.c
 - Remove the comment at the top regarding older Libevent versions.
 - Remove the cast and comment on line 268.

 src/common/procmon.c
 - Make `poll_interval_tv` const on line 166.
 - Remove the subsequent comment because it's obsolete now.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/19554#comment:3>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs