Re: [tor-bugs] #19567 [Core Tor/Tor]: SR: Fix issues Coverity found:

["Tor Bug Tracker & Wiki" <blackhole@xxxxxxxxxxxxxx>]

#19567: SR: Fix issues Coverity found:
--------------------------+------------------------------------
 Reporter:  dgoulet       |          Owner:
     Type:  defect        |         Status:  needs_review
 Priority:  High          |      Milestone:  Tor: 0.2.9.x-final
Component:  Core Tor/Tor  |        Version:
 Severity:  Normal        |     Resolution:
 Keywords:  tor-sr test   |  Actual Points:
Parent ID:                |         Points:  0.1
 Reviewer:                |        Sponsor:  SponsorR-must
--------------------------+------------------------------------

Comment (by asn):

 Patch looks good.

 One question. You seem to have removed setting `*next` to NULL there.

 {{{
    next = &sr_disk_state->SharedRandValues;
 -  *next = NULL;
    if (sr_state->previous_srv != NULL) {
 }}}

 Is there a reason for this removal?  The coverity report does not seem
 related.

 This pattern seems to also exist in other parts of the code (e.g. in
 `entry_guards_update_state()` and `circuit_build_times_update_state()`.
 Are we sure we don't need it?

 It might be useful in case our state does not contain previous or current
 SRVs.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/19567#comment:3>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs