[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]
Re: [tor-bugs] #18923 [Applications/Tor Browser]: Add a script in tor-browser.git to run all of our TBB-specific regression tests
#18923: Add a script in tor-browser.git to run all of our TBB-specific regression
tests
--------------------------------------+------------------------------
Reporter: arthuredelstein | Owner: tbb-team
Type: enhancement | Status: needs_review
Priority: Medium | Milestone:
Component: Applications/Tor Browser | Version:
Severity: Normal | Resolution:
Keywords: TorBrowserTeam201607R | Actual Points:
Parent ID: | Points:
Reviewer: | Sponsor:
--------------------------------------+------------------------------
Comment (by boklm):
Replying to [comment:7 gk]:
> Just two nits:
>
> 1) Could you put quotes around `echo The following tests will be run:`
> 2) `echo $'\n' 'Starting tests'` leads to a one character indentation.
We might want to have `echo $'\n''Starting tests'` instead?
Thanks. I attached a new version of the patch with those changes.
>
> This script takes only care of Mochitest tests so far which is fine to
me as we don't have e.f. XPCShell tests right now. We should keep that in
mind, though, and adapt the script as soon as this changes.
Yes. I added a comment at the top of the script to remind us that it only
runs Mochitest tests.
--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/18923#comment:8>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs