[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

Re: [tor-bugs] #3291 [Pluggable transport]: obfs2 should wait before closing connection on wrong magic/plength

#3291: obfs2 should wait before closing connection on wrong magic/plength
---------------------------------+------------------------------------------
 Reporter:  asn                  |          Owner:  asn         
     Type:  defect               |         Status:  needs_review
 Priority:  normal               |      Milestone:              
Component:  Pluggable transport  |        Version:              
 Keywords:                       |         Parent:              
   Points:                       |   Actualpoints:              
---------------------------------+------------------------------------------

Comment(by nickm):

 Hm.  The event_set interface is deprecated.  Why not use event_new() ?

 Also, what frees the event we calloc there?  It looks like it leaks.

 Also, let's not abbreviate "libevent" as "libev" -- there's another
 project out there called "libev".

 Looks like set_rand_timeout() has an undocumented maximum value.

 In crypto_rand_int ... never copy code without crediting the source.

-- 
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/3291#comment:8>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs