[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

Re: [tor-bugs] #9066 [Tor]: use a macro like CHECK_PRINTF for tor_sscanf



#9066: use a macro like CHECK_PRINTF for tor_sscanf
--------------------+-------------------------------------------------------
 Reporter:  x3j11   |          Owner:                     
     Type:  defect  |         Status:  new                
 Priority:  normal  |      Milestone:  Tor: 0.2.5.x-final 
Component:  Tor     |        Version:  Tor: 0.2.4.12-alpha
 Keywords:          |         Parent:                     
   Points:          |   Actualpoints:                     
--------------------+-------------------------------------------------------

Comment(by nickm):

 >presumably sufficiently old gccs don't have those extensions, and they're
 useful enough that some non-gcc compiler might implement compatible ones -
 either now without my being aware of it, or in the future.

 They were introduced in gcc 2.0, which was released in 1992 -- we will
 never want to build with a GCC that old, I think.  (I tried to bootstrap
 gcc 2.0 for the fun of it, but it doesn't even build cleanly any more.)

 There are also compilers that support this extension: notably, clang and
 (I believe) icc.  But they both define __GNUC__ to indicate that they
 support the usual GCC extensions.

 I'll consider the other points when I'm more awake, but I wanted to
 braindump the above stuff before I forgot it.

-- 
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/9066#comment:6>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs