[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

Re: [tor-bugs] #11246 [Tor]: Count data cells with stream-id 0 as delivered for SENDME purposes

#11246: Count data cells with stream-id 0 as delivered for SENDME purposes
-------------------------+-------------------------------------------------
     Reporter:  nickm    |      Owner:
         Type:  defect   |     Status:  needs_review
     Priority:  normal   |  Milestone:  Tor: 0.2.5.x-final
    Component:  Tor      |    Version:
   Resolution:           |   Keywords:  tor-relay, 025-triaged andrea-
Actual Points:           |  review-0255
       Points:           |  Parent ID:
-------------------------+-------------------------------------------------

Comment (by andrea):

 So, if I understand correctly, all we're doing here is moving the log and
 return down below the circuit window code for the RELAY_COMMAND_DATA case?

 I think this is okay, but it makes it possible for
 connection_edge_process_relay_cell_not_open() to get called in the
 stream_id == 0 case.  I *think* that's harmless, but adding a stream_id !=
 0 test to that if clause as well may be the slightly more cautious route.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/11246#comment:5>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs