[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

Re: [tor-bugs] #16366 [Tor]: tor hangs for 30 seconds when parsing torrc ending in backslash-newline

#16366: tor hangs for 30 seconds when parsing torrc ending in backslash-newline
------------------------+--------------------------
     Reporter:  teor    |      Owner:
         Type:  defect  |     Status:  new
     Priority:  minor   |  Milestone:  Tor: 0.2.???
    Component:  Tor     |    Version:  Tor: 0.2.6.8
   Resolution:          |   Keywords:  lorax
Actual Points:          |  Parent ID:
       Points:          |
------------------------+--------------------------

Comment (by teor):

 Oh, I completely agree, the attached test program causes the issue to
 occur on OS X, but not on Linux. And all it contains is a simple
 `getaddrinfo` call that any program could use.

 I don't know if it's worth filtering obvious invalid addresses like `\`
 and `\n` and `\r` or not. Since we are already parsing and validating
 address/port combinations, should we do a very simple validity check with
 the name part? (Do we already do some checks? Or do we leave everything
 before the colon to `getaddrinfo`?)

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/16366#comment:6>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs