[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

Re: [tor-bugs] #19285 [Metrics/metrics-lib]: Parse "package" lines in consensuses using method 19 or later

#19285: Parse "package" lines in consensuses using method 19 or later
---------------------------------+------------------------------
 Reporter:  karsten              |          Owner:  karsten
     Type:  enhancement          |         Status:  needs_review
 Priority:  Medium               |      Milestone:
Component:  Metrics/metrics-lib  |        Version:
 Severity:  Normal               |     Resolution:
 Keywords:                       |  Actual Points:
Parent ID:  #19398               |         Points:
 Reviewer:                       |        Sponsor:
---------------------------------+------------------------------

Comment (by iwakeh):

 All fine, only the `@Override` annotation is missing in the new (and old)
 methods.

 And, out of curiosity: Is this `if (line.length() > "package ".length())`
 a precaution? An incomplete line is not allowed according to the protocol
 above (afaict)?
 There is no test with an incomplete line.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/19285#comment:3>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs