[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

Re: [tor-bugs] #18322 [Core Tor/Tor]: Log unparseable votes so they can be analysed

#18322: Log unparseable votes so they can be analysed
----------------------------------------+----------------------------------
 Reporter:  teor                        |          Owner:  andrea
     Type:  defect                      |         Status:  assigned
 Priority:  Medium                      |      Milestone:  Tor:
Component:  Core Tor/Tor                |  0.2.9.x-final
 Severity:  Normal                      |        Version:
 Keywords:  tor-dos, TorCoreTeam201606  |     Resolution:
Parent ID:  #17293                      |  Actual Points:
 Reviewer:                              |         Points:  2
                                        |        Sponsor:  SponsorU-can
----------------------------------------+----------------------------------

Comment (by andrea):

 I think the simplest solution here is to modify dump_desc() in
 routerparse.c to include the hash of the offending descriptor in the
 filename and then mention the hash in the log message about the parse
 failure.  This potentially allows someone to exhaust disk space by
 uploading a lot of bogus descriptors, though, so we'll need to either have
 a way to clean up old logged descriptors or otherwise limit that, or
 restrict it only to cases where the unparseable material can't have come
 from an arbitrary source.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/18322#comment:11>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs