[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

Re: [tor-bugs] #30733 [Core Tor/sbws]: sbws does not detect changes in descriptor bandwidth values

#30733: sbws does not detect changes in descriptor bandwidth values
-----------------------------------+-----------------------------------
 Reporter:  starlight              |          Owner:  juga
     Type:  defect                 |         Status:  needs_revision
 Priority:  Very High              |      Milestone:  sbws: 1.1.x-final
Component:  Core Tor/sbws          |        Version:  sbws: 1.1.0
 Severity:  Critical               |     Resolution:
 Keywords:  sbws-majority-blocker  |  Actual Points:
Parent ID:                         |         Points:
 Reviewer:                         |        Sponsor:
-----------------------------------+-----------------------------------
Changes (by teor):

 * status:  assigned => needs_revision


Comment:

 I did a review of this pull request: the code looks good, but one of the
 comments is wrong.

 See my comment on the pull request:
 https://github.com/torproject/sbws/pull/358/commits/2b3860678595dc8a1f26ab93bc6cef54fe796a7d#r294117174

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/30733#comment:23>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online

_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs