[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

Re: [tor-bugs] #2563 [Metrics]: Add R code for processing Torperf data to the Torperf repository

#2563: Add R code for processing Torperf data to the Torperf repository
--------------------------------------+-------------------------------------
 Reporter:  karsten                   |          Owner:  tomb    
     Type:  enhancement               |         Status:  assigned
 Priority:  normal                    |      Milestone:          
Component:  Metrics                   |        Version:          
 Keywords:  TorPerfIteration20110305  |         Parent:          
   Points:  3                         |   Actualpoints:          
--------------------------------------+-------------------------------------
Changes (by karsten):

  * status:  needs_review => assigned


Comment:

 Your branch looks great and works for me!  Here are a few minor comments:

  - Can you update `README` to list the three new files and describe what
 they do?
  - The usage example in your `HOWTO` (line 81) should have the `--slave`
 flag, too.
  - You have a FIXME comment in your `filter.R`, but I couldn't reproduce
 this problem.  Can you try to reproduce it?  If not, we should take out
 the FIXME comment.
  - I'd like to squash all your commits into one, because the development
 history would be very confusing for people.  Do you mind?  And can you
 write a commit message in your last commit that you'd want to see for the
 single squashed commit?

 Please set the needs_review bit again when you're happy with your branch,
 and I'll merge it into the official Torperf branch.  Thanks!

-- 
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/2563#comment:8>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs