[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

Re: [tor-bugs] #2536 [Tor Relay]: Disable outgoing token bucket and reduce token bucket refill interval



#2536: Disable outgoing token bucket and reduce token bucket refill interval
-------------------------+--------------------------------------------------
 Reporter:  karsten      |          Owner:                    
     Type:  enhancement  |         Status:  needs_review      
 Priority:  normal       |      Milestone:  Tor: 0.2.3.x-final
Component:  Tor Relay    |        Version:                    
 Keywords:               |         Parent:                    
   Points:               |   Actualpoints:                    
-------------------------+--------------------------------------------------

Comment(by nickm):

 I am skeptical about the "decrement the in-bucket when traffic is
 'generated internally' " approach.  It seems that it would require
 pervasive changes throughout the codebase.  I bet that the "adaptively
 decrease the read-rate until the write-limit is (almost) never reached)"
 approach would yield significantly more reliable and maintainable code.

 As for separating stuff: I meant separate patches, so that the features
 can be merged and reviewed independently.  If the short-refill-interval
 approach yields significant improvements, it shouldn't have to wait for
 the double-gating fixes to get revised.  I just talked to Karsten and
 Sebastian, and they said they'd like to try to split up the patch series
 into independent patches.  That'd be great!

-- 
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/2536#comment:5>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs