[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

Re: [tor-bugs] #3894 [Tor Client]: Fix compilation on FreeBSD 4



#3894: Fix compilation on FreeBSD 4
---------------------------+------------------------------------------------
    Reporter:  nickm       |       Owner:                    
        Type:  defect      |      Status:  needs_revision    
    Priority:  normal      |   Milestone:  Tor: 0.2.2.x-final
   Component:  Tor Client  |     Version:  Tor: 0.2.2.35     
  Resolution:              |    Keywords:                    
      Parent:              |      Points:                    
Actualpoints:              |  
---------------------------+------------------------------------------------
Changes (by nickm):

  * status:  reopened => needs_revision


Comment:

 Hm.  I'm not too happy about using "#ifdef __FreeBSD__" instead of actual
 autoconf checks or #ifdef checks for questions like "Is SIZE_MAX defined."
 Similarly, I'm not too happy with defining MAX_CAPACITY based on UINT_MAX
 -- doesn't FreeBSD work on 64-bit systems? On such systems, size_t can get
 up to UINT64_MAX.  It's probably better to define SIZE_MAX in torint.h ,
 if it's not already defined.

 Similarly, for the MIN/MAX stuff, why not include sys/param.h if it
 exists, and then let the #ifndef MIN and #ifndef MAX .

 The %lf -> %f fixes are legit and should go in as-is.

 It's fine to initialize the two variables above at declaration time to
 suppress those warnings.

-- 
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/3894#comment:7>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs