Re: [tor-bugs] #3634 [Vidalia]: Better support of multiple tor relays

["Tor Bug Tracker & Wiki" <torproject-admin@xxxxxxxxxxxxxx>]

#3634: Better support of multiple tor relays
-------------------------+--------------------------------------------------
 Reporter:  joergent     |          Owner:  chiiph         
     Type:  enhancement  |         Status:  needs_revision 
 Priority:  normal       |      Milestone:                 
Component:  Vidalia      |        Version:  Vidalia: 0.2.12
 Keywords:               |         Parent:                 
   Points:               |   Actualpoints:                 
-------------------------+--------------------------------------------------
Changes (by chiiph):

  * status:  needs_review => needs_revision


Comment:

 Three minor things and we are there:

 - This:

 {{{

 setWindowTitle(baseTitle + " - " + Nickname + " " + ORPort);

 }}}

 Should be something like this:

 {{{

 setWindowTitle(QString("%1 - %2 %3").arg(baseTitle)
                                     .arg(Nickname)
                                     .arg(ORPort));

 }}}

 So that the format is easy to change.

 - The line with "this" in the connect is badly indented.
 - You probably want to emit the configChanged() signal only when something
 was changed, not all the time. In fact, we just want it the times
 ServerPage changed, but since the signal is pretty generic, we will have
 to emit it when any page has changed.

-- 
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/3634#comment:7>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs