Re: [tor-bugs] #8402 [Tor]: Tor should help its transport proxy use a proxy, if needed.

["Tor Bug Tracker & Wiki" <blackhole@xxxxxxxxxxxxxx>]

#8402: Tor should help its transport proxy use a proxy, if needed.
------------------------+--------------------------------------
     Reporter:  asn     |      Owner:
         Type:  defect  |     Status:  needs_review
     Priority:  normal  |  Milestone:  Tor: 0.2.6.x-final
    Component:  Tor     |    Version:
   Resolution:          |   Keywords:  tor-bridge pt flashproxy
Actual Points:          |  Parent ID:
       Points:          |
------------------------+--------------------------------------

Comment (by asn):

 Nice!

 A few comments from a preliminary review. I would like to review it once
 again:

 - As we discussed in IRC, unit tests for the non-trivial additions would
 be great.

 - Maybe we could functionify the new duplicate code in
 `get_proxy_addrport()`. I know that Nick hates duplicate code, and I share
 his sentiments.

 - This is more of a comment to the original proposal, but isn't `PROXY
 true` a bit off in a protocol that doesn't have any other `false`/`true`
 strings? Maybe `PROXY DONE` is more appropriate? Maybe not.

 - `acked_proxy` is a bit of a deceiving name. Maybe we should change the
 variable name to imply some connection to the proxy?

 Other than that, patch looks very promising!

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/8402#comment:14>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs