[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

Re: [tor-bugs] #14429 [Tor Browser]: Automated rounding of content window dimensions

#14429: Automated rounding of content window dimensions
-------------------------+-------------------------------------------------
     Reporter:           |      Owner:  arthuredelstein
  arthuredelstein        |     Status:  needs_revision
         Type:  defect   |  Milestone:
     Priority:  normal   |    Version:
    Component:  Tor      |   Keywords:  tbb-fingerprinting-resolution, tbb-
  Browser                |  torbutton, tbb-4.5-alpha,
   Resolution:           |  TorBrowserTeam201503R, GeorgKoppen201503R
Actual Points:           |  Parent ID:
       Points:           |
-------------------------+-------------------------------------------------

Comment (by arthuredelstein):

 Replying to [comment:34 gk]:
 > I have so far 3-4 issues to report all on a normal Windows 7 box:

 Thanks for testing!

 > 1) I get (after maximizing) 1586X700 back (no DPI messing involved just
 the default 100% is used).

 That is interesting. I always see properly quantized
 window.innerWidth/innerHeight on my Windows machine after maximizing. Are
 there any error messages being printed in the browser console?

 > 2) If I play with my DPI value (a lot of complains about the current
 resize code running during start-up are related due to non-default DPI
 values) and increase the size of text etc. to 150% and start Tor Browser,
 I can see how the resizing is step-wise ongoing until my height is only
 100 and the browser is basically not usable for me. I end up with
 DPI_issue1.png which is attached.
 > 3)
 > a) If I enlarge the text etc. to 125%, I start with 1000x500 which is
 good but maximizing leads sometimes to 1200x400
 > b) If a) is the case and I drag the window out to the left it gets
 resized to 600x500 (which is okay). But if I maximize the window now, I am
 left with 1200x499 (which happens as well after resizing if a) is not
 happening).

 How are you measuring these dimensions? Are you using
 window.innerWidth/innerHeight in the web console? At this point, zoomed
 pages should not be giving properly quantized values at all. As I have
 mentioned above, I haven't made any attempt to deal with zooming at this
 stage. For the case where the user zooms one tab to 125% and leaves the
 other at 100%, we will need to introduce a mechanism that leaves at least
 one tab with empty margins. My thinking was that it was more important to
 get it working on various platforms at 100% zoom.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/14429#comment:35>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs