[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

Re: [tor-bugs] #21576 [Core Tor/Tor]: Bug: Assertion linked_dir_conn_base failed in connection_ap_handshake_send_begin



#21576: Bug: Assertion linked_dir_conn_base failed in
connection_ap_handshake_send_begin
---------------------------------+------------------------------------
 Reporter:  alecmuffett          |          Owner:  teor
     Type:  defect               |         Status:  merge_ready
 Priority:  Medium               |      Milestone:  Tor: 0.3.0.x-final
Component:  Core Tor/Tor         |        Version:  Tor: 0.2.9.3-alpha
 Severity:  Normal               |     Resolution:
 Keywords:  crash, 029-backport  |  Actual Points:  0.5
Parent ID:                       |         Points:  0.2
 Reviewer:                       |        Sponsor:
---------------------------------+------------------------------------
Changes (by asn):

 * status:  needs_review => merge_ready


Comment:

 I'm a big newbie with this part of the codebase (particularly linked
 connections and how they work), but the fix looks reasonable given the
 description above, and it doesn't seem like it can make matters worse.

 I guess a side-question is whether that's the best place in the codebase
 to bail if the linked connection does not exist. Maybe we shouldn't even
 start sending the BEGIN cell if the linked conn has been teared down?

 Anyway, I think Nick will be better to evaluate this patch, so I'm marking
 this as `merge_ready`.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/21576#comment:7>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs