[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

Re: [tor-bugs] #21723 [Applications/Tor Browser]: Fix inconsistent generation of MOZ_MACBUNDLE_ID

#21723: Fix inconsistent generation of MOZ_MACBUNDLE_ID
--------------------------------------+------------------------------
 Reporter:  teor                      |          Owner:  tbb-team
     Type:  defect                    |         Status:  needs_review
 Priority:  Medium                    |      Milestone:
Component:  Applications/Tor Browser  |        Version:
 Severity:  Normal                    |     Resolution:
 Keywords:  TorBrowserTeam201703R     |  Actual Points:
Parent ID:  #17670                    |         Points:
 Reviewer:                            |        Sponsor:
--------------------------------------+------------------------------

Comment (by mcs):

 Thanks for working on this. I have not tested this, but a quick glance at
 the uses of MOZ_MACBUNDLE_NAME within the browser code tells me we may not
 want to force it to lowercase because doing so will change our .app bundle
 from TorBrowser.app to torbrowser.app which is is less OSX-like and may
 also require changes to our packaging scripts, etc.

 MOZ_MACBUNDLE_ID should definitely be fixed though, and I like
 org.torproject.torbrowser better than org.mozilla.torbrowser (but that
 will require a larger patch or scarier build config changes).

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/21723#comment:2>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs