[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]
Re: [tor-bugs] #29221 [Core Tor/Tor]: Tooling to track code-style/best-practices violations
#29221: Tooling to track code-style/best-practices violations
-------------------------------------------------+-------------------------
Reporter: nickm | Owner: (none)
Type: enhancement | Status:
| needs_revision
Priority: Medium | Milestone: Tor:
| 0.4.1.x-final
Component: Core Tor/Tor | Version:
Severity: Normal | Resolution:
Keywords: network-team-roadmap-2019-Q1Q2 | Actual Points:
teor-merge |
Parent ID: | Points: 3
Reviewer: nickm | Sponsor:
| Sponsor31-can
-------------------------------------------------+-------------------------
Comment (by asn):
Replying to [comment:18 teor]:
> Sorry, that didn't seem to fix CI.
Almost there. The problem with your fix was that you added a problem line
for `hs_cell.c:hs_cell_parse_introduce2` but there was already one in the
exceptions file. Since the second one was more down it had more priority
(having two same problems in the exception file is currently UB).
Perhaps we can soft-solve this problem by editing the right exception
line, and then as part of #29746 we can figure out what to do about
double exception lines?
--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/29221#comment:19>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs