[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

Re: [tor-bugs] #29136 [Core Tor/Tor]: PT_LOG and PT_STATUS event fields unspecifed



#29136: PT_LOG and PT_STATUS event fields unspecifed
----------------------------------------+----------------------------------
 Reporter:  atagar                      |          Owner:  ahf
     Type:  defect                      |         Status:  needs_review
 Priority:  High                        |      Milestone:  Tor:
                                        |  0.4.0.x-final
Component:  Core Tor/Tor                |        Version:
 Severity:  Normal                      |     Resolution:
 Keywords:  tor-spec, tor-pt, 040-must  |  Actual Points:
Parent ID:                              |         Points:
 Reviewer:                              |        Sponsor:
----------------------------------------+----------------------------------

Comment (by ahf):

 That would be pretty nice to have both in the PT spec, but also in the
 Control spec, as it's the same format that is going through here and we
 plan on use this in more places in the future as it makes it easier to
 extend the messages later on.

 Let me link you with some relevant code:

 - The K/V line parser itself in very clean C code written by Nick:
 https://github.com/torproject/tor/blob/2f683465d4b666c5d8f84fb3b234ad539d8511cd/src/lib/encoding/kvline.c
 - The current test cases for the K/V line parser:
 https://github.com/torproject/tor/blob/2f683465d4b666c5d8f84fb3b234ad539d8511cd/src/test/test_config.c#L5820

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/29136#comment:14>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs