[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

[tor-bugs] #29898 [Core Tor/Tor]: How can we automatically add #else and #endif comments?

#29898: How can we automatically add #else and #endif comments?
-------------------------------+--------------------------------
     Reporter:  teor           |      Owner:  (none)
         Type:  defect         |     Status:  new
     Priority:  Medium         |  Milestone:  Tor: 0.4.1.x-final
    Component:  Core Tor/Tor   |    Version:
     Severity:  Normal         |   Keywords:  technical-debt
Actual Points:                 |  Parent ID:
       Points:  0.1            |   Reviewer:
      Sponsor:  Sponsor31-can  |
-------------------------------+--------------------------------
 In 0.3.5? we ran a script to automatically add comments to #else and
 #endif blocks. These comments help us work out how these macros are
 nested.

 But since then, we've added new #else and #endif without the comments.

 Should we run the script again in 0.4.1?
 Should we run it before we branch off each new maint branch?
 Should we automatically run it before we commit or merge?

 I hope nickm has some good feedback on this idea.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/29898>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online

_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs