[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

Re: [tor-bugs] #33531 [Core Tor/Tor]: surprise newline in info-level cbt log

#33531: surprise newline in info-level cbt log
--------------------------+------------------------
 Reporter:  arma          |          Owner:  (none)
     Type:  defect        |         Status:  new
 Priority:  Medium        |      Milestone:
Component:  Core Tor/Tor  |        Version:
 Severity:  Normal        |     Resolution:
 Keywords:                |  Actual Points:
Parent ID:                |         Points:
 Reviewer:                |        Sponsor:
--------------------------+------------------------

Comment (by arma):

 I did a bit of grepping to look for other cases. I don't think we can
 simply disallow \n in log strings, since there are plenty of multi-line
 log strings.

 But then I got to thinking: maybe we can disallow log strings that *end*
 in \n?

 I found a couple of those, like in fuzz_main():
 {{{
     log_debug(LD_GENERAL, "Zero-Length-Input\n");
 }}}
 {{{
   log_debug(LD_GENERAL, "Result:\n%d\n", rv);
 }}}

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/33531#comment:1>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online

_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs