[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

Re: [tor-bugs] #33090 [Metrics/Library]: Make all Descriptor implementors serializable



#33090: Make all Descriptor implementors serializable
-----------------------------+------------------------------
 Reporter:  notirl           |          Owner:  metrics-team
     Type:  enhancement      |         Status:  needs_review
 Priority:  High             |      Milestone:
Component:  Metrics/Library  |        Version:
 Severity:  Normal           |     Resolution:
 Keywords:                   |  Actual Points:
Parent ID:                   |         Points:
 Reviewer:  irl              |        Sponsor:
-----------------------------+------------------------------
Changes (by karsten):

 * status:  new => needs_review
 * priority:  Medium => High
 * cc: metrics-team (added)
 * reviewer:   => irl


Comment:

 Alright, I have a branch that I tested with CollecTor's `recent/`
 directory and which might also work for your use case. (The trick with
 that TreeMap was to turn the lambda comparator into its own serializable
 `Comparator` class. It's not that all TreeMaps are non-serializable,
 AFAIK.)

 Can you give this branch a try? The patch is
 [https://gitweb.torproject.org/user/karsten/metrics-
 lib.git/commit/?h=task-33090&id=e2fc2cb14dbd2ff6db0a062cdec2c9815bbbbb7f
 commit e2fc2cb in my task-33090 branch].

 We should soon decide about revising/merging this branch, because it has
 high potential of creating merge conflicts with all the files it touches.
 Setting priority to high for that reason.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/33090#comment:3>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs