[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

Re: [tor-bugs] #33451 [Core Tor/Tor]: Write a script to install git tools and hooks



#33451: Write a script to install git tools and hooks
--------------------------+------------------------------------
 Reporter:  nickm         |          Owner:  nickm
     Type:  defect        |         Status:  merge_ready
 Priority:  Medium        |      Milestone:  Tor: 0.4.4.x-final
Component:  Core Tor/Tor  |        Version:
 Severity:  Normal        |     Resolution:
 Keywords:                |  Actual Points:  .1
Parent ID:                |         Points:
 Reviewer:  teor          |        Sponsor:
--------------------------+------------------------------------
Changes (by teor):

 * status:  needs_review => merge_ready


Comment:

 I didn't run it, but it looks fine to me.

 I opened #33603 to follow up the comment about bash "unofficial strict
 mode". (Shellcheck already gets us some of these things, but runtime
 checks are also helpful.)

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/33451#comment:4>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs