[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

Re: [tor-bugs] #32588 [Core Tor/Tor]: Setting ORPort [ipv6]:auto mistakenly advertises port 94



#32588: Setting ORPort [ipv6]:auto mistakenly advertises port 94
-------------------------------------------------+-------------------------
 Reporter:  arma                                 |          Owner:  nickm
     Type:  defect                               |         Status:
                                                 |  accepted
 Priority:  Medium                               |      Milestone:  Tor:
                                                 |  0.4.3.x-final
Component:  Core Tor/Tor                         |        Version:  Tor:
                                                 |  0.2.3.9-alpha
 Severity:  Normal                               |     Resolution:
 Keywords:  043-should, ipv6, memory-safety,     |  Actual Points:  1
  security-low, 035-backport, 040-backport,      |
  041-backport, 042-backport                     |
Parent ID:  #33048                               |         Points:  1
 Reviewer:  ahf                                  |        Sponsor:
                                                 |  Sponsor55-must
-------------------------------------------------+-------------------------

Comment (by teor):

 Replying to [comment:35 nickm]:
 > FWIW, this isn't an "uninitialized RAM" bug: The reason it says 94 is
 that the "ipv6_port" field in the cfg_port_t is set to CFG_AUTO_PORT,
 which is 0xc4005e in hex.  Once that's cast to a uint16_t, we get 0x5e,
 which is 94.

 That makes sense! I misread the hex constant as 0x405e, so I couldn't work
 out how the cast was doing that, without some memory misalignment.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/32588#comment:38>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs