[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

Re: [tor-bugs] #3076 [Tor Client]: Implement 'SocksPort auto' and 'ControlPort auto'

#3076: Implement 'SocksPort auto' and 'ControlPort auto'
-------------------------+--------------------------------------------------
 Reporter:  mikeperry    |          Owner:                    
     Type:  enhancement  |         Status:  needs_review      
 Priority:  major        |      Milestone:  Tor: 0.2.2.x-final
Component:  Tor Client   |        Version:                    
 Keywords:               |         Parent:  #2264             
   Points:               |   Actualpoints:                    
-------------------------+--------------------------------------------------

Comment(by nickm):

 Agreed except for:

 > In control_ports_write_to_file in  commit
 1a9a29e73efa1771f772e5a411da15d643c56afe, you're joining strings using the
 empty string as a separator; you want to use "\n" instead.

 The strings that I'm joining there are already NL-terminated.

-- 
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/3076#comment:21>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs