[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]
Re: [tor-bugs] #5810 [Stem]: Implement verification of server descriptor
#5810: Implement verification of server descriptor
-------------------------+--------------------------------------------------
Reporter: reganeet | Owner: reganeet
Type: enhancement | Status: new
Priority: normal | Milestone:
Component: Stem | Version:
Keywords: | Parent:
Points: | Actualpoints:
-------------------------+--------------------------------------------------
Comment(by reganeet):
Hi Damian,
I've written the unit test and pushed into my repo:
https://github.com/beckbaibai/stem
In the test file for server descriptor, I added the correct fingerprint
into RELAY_DESCRIPTOR_ATTR, and test_minimal_relay_descriptor() will now
check if it has been read correctly. Another test case,
test_fingerprint_malformed(), is added to make sure the construction will
fail if the fingerprint does not match the signing key.
Notice that after the second part of the validation is implemented,
testing would become more complicated, because the signature has to match
the hash of the content, and signed with descriptor's signing key (the
private one).
I think I've merged my branch with yours in the right way...but please
double check since I'm still not comfortable with git merge.
Thanks!
Beck
--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/5810#comment:8>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs