[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

Re: [tor-bugs] #5262 [Stem]: Implement Safe Cookie in Stem

#5262: Implement Safe Cookie in Stem
-------------------------+--------------------------------------------------
 Reporter:  atagar       |          Owner:  neena         
     Type:  enhancement  |         Status:  needs_revision
 Priority:  normal       |      Milestone:                
Component:  Stem         |        Version:                
 Keywords:               |         Parent:                
   Points:               |   Actualpoints:                
-------------------------+--------------------------------------------------
Changes (by atagar):

  * status:  needs_review => needs_revision


Comment:

 Hazaa! Looks great.

 > I thought having seperate exceptions would be a good idea. But, now,
 after implementing both, I think having an attribute with the
 authentication method is quite neat.

 Agreed. Lets go with that one.

 Glad to see those changes to ControlMessage, definitely makes it more
 usable.

 As mentioned on IRC, we're probably getting close enough to merging that
 I'd rather wait to do a real review when we have the tests. That said,
 what I'm seeing here looks great! -Damian

-- 
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/5262#comment:8>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs