[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

Re: [tor-bugs] #11417 [Tor Weather]: add vagrant file for weather



#11417: add vagrant file for weather
-----------------------------+-----------------------------
     Reporter:  feverDream   |      Owner:  baumanno
         Type:  task         |     Status:  needs_review
     Priority:  normal       |  Milestone:
    Component:  Tor Weather  |    Version:
   Resolution:               |   Keywords:  weather-rewrite
Actual Points:               |  Parent ID:
       Points:               |
-----------------------------+-----------------------------

Comment (by karsten):

 Looks good.  Last concern: the following change doesn't look correct
 (found in `git diff 8f3f07d..`):

 {{{
 -        'NAME': PROJECT_PATH + "/../var/WeatherDB",
 # Or p
 +        'NAME': os.path.join(PROJECT_PATH, 'var', 'WeatherDB'),
 }}}

 After that is resolved, how about we squash all commits since 8f3f07d into
 a ''single'' commit and list everyone who helped out with this commit in
 the commit message?

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/11417#comment:15>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs