[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

Re: [tor-bugs] #10819 [Firefox Patch Issues]: Create preference for DOM storage isolation and image cache isolation



#10819: Create preference for DOM storage isolation and image cache isolation
-------------------------------------+-------------------------------------
     Reporter:  mikeperry            |      Owner:  mikeperry
         Type:  enhancement          |     Status:  new
     Priority:  normal               |  Milestone:
    Component:  Firefox Patch        |    Version:
  Issues                             |   Keywords:  tbb-mozilla-merge,
   Resolution:                       |  interview, MikePerry201405R
Actual Points:                       |  Parent ID:  #10820
       Points:                       |
-------------------------------------+-------------------------------------

Comment (by mcs):

 Mike asked Kathy Brade and me to review this patch (he is reviewing it as
 well).  Here are our comments:

 What is the effect on the other subsystems?  If first party isolation is
 disabled, we probably want everything to work just like it does in
 Firefox.  For imageLoader, it looks like values generated by GetCacheKey()
 will still be different than in Firefox.  For DOM storage, it looks like
 using a NULL URI will return everything to the original Firefox behavior.
 But please verify if you have not already done so.

 Unless is needs to be called from elsewhere, IsFirstPartyIsolationActive()
 should be a private method.

 IsFirstPartyIsolationActive() should avoid getting the channel and
 checking for private browsing mode if the pref value is 0 or 2.

 ThirdPartyUtil::GetFirstPartyIsolationURI() should check the return value
 from IsFirstPartyIsolationActive.  Also, please initialize isolationActive
 when it is declared.  Note that if IsFirstPartyIsolationActive() is
 converted to a private method that returns a bool, these issues disappear.

 Renaming firstPartyURI to firstPartyIsolationURI everywhere makes for a
 large diff but it is a reasonable thing to do, especially if these new
 changes are collapsed with the original image loader and DOM storage
 patches.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/10819#comment:8>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs