[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]
Re: [tor-bugs] #25705 [Core Tor/Tor]: Refactor circuit_build_failed to separate build vs path failures
#25705: Refactor circuit_build_failed to separate build vs path failures
--------------------------+------------------------------------
Reporter: mikeperry | Owner: (none)
Type: defect | Status: merge_ready
Priority: Medium | Milestone: Tor: 0.3.4.x-final
Component: Core Tor/Tor | Version:
Severity: Normal | Resolution:
Keywords: | Actual Points:
Parent ID: #25546 | Points:
Reviewer: asn | Sponsor: SponsorV-can
--------------------------+------------------------------------
Comment (by mikeperry):
Ok I added the ratelimit log message and put this on maint-0.3.3 under
mikeperry/bug25705_v3_033.
I think an 0.3.3 backport makes sense, because it would be nice to have
this type of checking in place for the HSLayerXNodes options. I am less
sure it needs a further backport since we nacked the #25347-related
change.
In addition to what asn said, the other thing that makes Roger's second
concern not happen is that this patch bails before incrementing
n_circuit_failures. So these failures won't trigger the "woah go to sleep"
property. I believe that is exactly what we want for these types of
failures, though. They should not cause us to blame the guard or give up
on the network. Neither are at fault.
--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/25705#comment:10>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs