Re: [tor-bugs] #25903 [Core Tor/Tor]: Add OVERHEAD and DELIVERED fields to CIRC_BW events

["Tor Bug Tracker & Wiki" <blackhole@xxxxxxxxxxxxxx>]

#25903: Add OVERHEAD and DELIVERED fields to CIRC_BW events
----------------------------------+------------------------------------
 Reporter:  mikeperry             |          Owner:  mikeperry
     Type:  defect                |         Status:  needs_revision
 Priority:  Medium                |      Milestone:  Tor: 0.3.4.x-final
Component:  Core Tor/Tor          |        Version:
 Severity:  Normal                |     Resolution:
 Keywords:  034-roadmap-proposed  |  Actual Points:
Parent ID:  #25546                |         Points:
 Reviewer:  isis                  |        Sponsor:
----------------------------------+------------------------------------
Changes (by isis):

 * status:  needs_review => needs_revision


Comment:

 Replying to [comment:12 mikeperry]:
 > Ok I think I found a bug in tor. I am not sure, but I think there should
 be a return in connection_edge_process_relay_cell_not_open() when the
 connected cell can't be parsed. The side effect of the parse failure is
 the addr will be AF_UNSPEC later, so I moved the accounting call inside
 that block.
 >
 > New pull request, this time with unit tests:
 https://github.com/torproject/tor/pull/101

 Okay, left a review for you on PR#101. There's just one small thing I'm
 worried about with an assert() not necessarily being true all the time in
 the future.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/25903#comment:13>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online

_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs