[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

[tor-bugs] #26082 [Core Tor/Tor]: control: ANY_EVENT_IS_INTERESTING() needs to mask the event before testing

#26082: control: ANY_EVENT_IS_INTERESTING() needs to mask the event before testing
------------------------------+-------------------------------------
     Reporter:  dgoulet       |      Owner:  dgoulet
         Type:  defect        |     Status:  assigned
     Priority:  Very High     |  Milestone:  Tor: 0.3.4.x-final
    Component:  Core Tor/Tor  |    Version:
     Severity:  Normal        |   Keywords:  tor-control, regression
Actual Points:                |  Parent ID:
       Points:                |   Reviewer:
      Sponsor:                |
------------------------------+-------------------------------------
 We merged very recently `0c19ce7bdece5906e035e71d3fb682632c8bb9cb` which
 introduced a problem that made all the control events to not work.

 In a nutshell, the macro `ANY_EVENT_IS_INTERESTING()` is doing it wrong.
 The event passed to the macro should be masked before tested using
 `EVENT_MASK_`. And we shouldn't use `EVENT_IS_INTERESTING()` which only
 apply to a single event.

 Fortunately, tor wasn't released so we can just fix it.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/26082>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online

_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs