[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

Re: [tor-bugs] #26127 [Applications/Tor Browser]: Make sure Torbutton and Tor Launcher are not treated as legacy extensions



#26127: Make sure Torbutton and Tor Launcher are not treated as legacy extensions
---------------------------------------------+--------------------------
 Reporter:  gk                               |          Owner:  tbb-team
     Type:  defect                           |         Status:  closed
 Priority:  Very High                        |      Milestone:
Component:  Applications/Tor Browser         |        Version:
 Severity:  Normal                           |     Resolution:  fixed
 Keywords:  ff60-esr, TorBrowserTeam201805R  |  Actual Points:
Parent ID:                                   |         Points:
 Reviewer:                                   |        Sponsor:
---------------------------------------------+--------------------------
Changes (by gk):

 * status:  needs_review => closed
 * resolution:   => fixed


Comment:

 Replying to [comment:4 arthuredelstein]:
 > Replying to [comment:3 gk]:
 > > A fix for this bug is up in my `bug_26127`
 (https://gitweb.torproject.org/user/gk/tor-
 browser.git/commit/?h=bug_26127&id=4eaeeb9b41e6509b97e3dd216a2e92572fc9b37b).
 Please review.
 >
 > I noticed it's possible to set "extensions.legacy.enabled" to false and
 you can still whitelist torbutton and tor-launcher using
 "extensions.legacy.exceptions". This might be a little safer by still
 providing a warning for any other legacy extensions installed.
 >
 > So I'd suggest removing the "extensions.legacy.enabled" line. The other
 two lines of code look good to me.

 Thanks. I did so and change the exception line and the comment a bit
 taking into account that we don't want to have a warning for the default
 them showing up as this is confusing. I removed the whitespace between the
 extension IDs as sukhbir suggested even though that does not matter.

 Applied to `tor-browser-60.0.1esr-8.0-1` as commit
 30544586f8a98e985e0038b2e905bfddb14e999e.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/26127#comment:5>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs