Re: [tor-bugs] #29231 [Core Tor/Tor]: Relays vastly underreport write-total in padding-counts line in extrainfo descriptor

["Tor Bug Tracker & Wiki" <blackhole@xxxxxxxxxxxxxx>]

#29231: Relays vastly underreport write-total in padding-counts line in extrainfo
descriptor
---------------------------------------+-----------------------------------
 Reporter:  arma                       |          Owner:  (none)
     Type:  defect                     |         Status:  merge_ready
 Priority:  Very High                  |      Milestone:  Tor:
                                       |  0.4.1.x-final
Component:  Core Tor/Tor               |        Version:
 Severity:  Normal                     |     Resolution:
 Keywords:  tor-relay padding wtf-pad  |  Actual Points:
Parent ID:  #28634                     |         Points:
 Reviewer:  dgoulet                    |        Sponsor:
---------------------------------------+-----------------------------------
Changes (by dgoulet):

 * status:  needs_review => merge_ready


Comment:

 lgtm;

 Just to clarify Mike, in `write_packed_cell()`, we count the cell only if
 the cell was successfully put in the connection buffer. Any error there
 will not count the cell.

 That it OK? As I recall some stats we want to count every cell, not just
 the ones that succeeded.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/29231#comment:8>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online

_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs