[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]
Re: [tor-bugs] #27130 [Core Tor/Tor]: rust dependency updating instructions don't work
#27130: rust dependency updating instructions don't work
-------------------------------------------------+-------------------------
Reporter: cyberpunks | Owner: nickm
Type: defect | Status:
| accepted
Priority: Medium | Milestone: Tor:
| unspecified
Component: Core Tor/Tor | Version: Tor:
| 0.3.3.9
Severity: Normal | Resolution:
Keywords: rust, doc, 033-unreached-backport, | Actual Points:
042-deferred-20190918 |
Parent ID: | Points:
Reviewer: nickm | Sponsor:
-------------------------------------------------+-------------------------
Comment (by teor):
Replying to [comment:26 cypherpunks]:
> `cargo vendor` was [https://github.com/rust-lang/cargo/pull/6869 merged]
in [https://blog.rust-lang.org/2019/08/15/Rust-1.37.0.html#built-in-cargo-
support-for-vendored-dependencies cargo 0.38] which came out August 15,
2019. (So if you tested this script in the 10 months between when the
branch was last reviewed in September 2018 and July 2019, you wouldn't
have had any issues.)
Some of our developer-only scripts aren't used that frequently. And we
haven't been doing much Rust work lately.
Is there a way to test this script in CI?
(The most reliable way for us to make sure that a test happens is to run
it on every commit.)
As a first step, we could run the script against whatever happens to be on
crates.io, and make sure it passes whether there are new crates or not.
In future, we may want to be notified when there are new versions of a
crate.
--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/27130#comment:27>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs