[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

Re: [tor-bugs] #2190 [Tor Client]: Possible reentrant calls to libevent from libevent logging callback

#2190: Possible reentrant calls to libevent from libevent logging callback
------------------------+---------------------------------------------------
 Reporter:  nickm       |       Owner:  nickm             
     Type:  defect      |      Status:  new               
 Priority:  normal      |   Milestone:  Tor: 0.2.2.x-final
Component:  Tor Client  |     Version:                    
 Keywords:              |      Parent:                    
------------------------+---------------------------------------------------

Comment(by nickm):

 The obvious easy fix is to never send log messages that arrive from
 libevent to any callback-based log backend.

 There is a harder fix: we could have a fix where instead of blocking
 libevent->controller log messages, we queue them in a list somewhere, and
 add a callback to play them back later.  This is probably a good idea for
 0.2.3 (and maybe 0.2.2) since it is not so great to keep controller users
 from seeing warnings.

-- 
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/2190#comment:1>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs