Re: [tor-bugs] #7195 [Tor]: Add a helpful warning log when a managed proxy dies during configuration

["Tor Bug Tracker & Wiki" <torproject-admin@xxxxxxxxxxxxxx>]

#7195: Add a helpful warning log when a managed proxy dies during configuration
--------------------+-------------------------------------------------------
 Reporter:  asn     |          Owner:                    
     Type:  defect  |         Status:  needs_review      
 Priority:  normal  |      Milestone:  Tor: 0.2.4.x-final
Component:  Tor     |        Version:                    
 Keywords:  pt      |         Parent:                    
   Points:          |   Actualpoints:                    
--------------------+-------------------------------------------------------

Comment(by nickm):

 Looks mostly okay, but I'm not sure about the message itself.  What is the
 user supposed to do about this?  The old message was,
 {{{
 "-      log_warn(LD_GENERAL, "Our communication channel with the managed
 proxy "
 -               "'%s' closed. Most probably application stopped running.",
 -               mp->argv[0]);"
 }}}
 which at least let you know, "Hey, there's a problem, maybe the managed
 proxy died."

 But the new message is,
 {{{
 +      log_warn(LD_GENERAL, "The communication stream of managed proxy
 '%s' "
 +               "is '%s'. The managed proxy will be destroyed.",
 +               mp->argv[0], stream_status_to_string(stream_status));
 }}}
 which implies that Tor is going to destroy something (scary!) and doesn't
 really tell the user what happened.

 IOW, what do we want people who see this message to know or do?  And how
 can we make a message that leads them to do that?

-- 
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/7195#comment:3>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs