[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

Re: [tor-bugs] #7347 [Ooni]: Drop the Old API



#7347: Drop the Old API
---------------------+------------------------------------------------------
 Reporter:  hellais  |          Owner:  hellais     
     Type:  defect   |         Status:  needs_review
 Priority:  normal   |      Milestone:              
Component:  Ooni     |        Version:              
 Keywords:           |         Parent:              
   Points:           |   Actualpoints:              
---------------------+------------------------------------------------------
Changes (by isis):

  * status:  new => needs_review


Comment:

 My bridge tests cannot be ported. Well, they can, but it means re-
 bootstrapping a Tor process for each bridge, since in the
 twisted.trial.unittest framework the reactor is specially handled and
 cleared in between tests, which would prevent me from attaching a long
 running process to it.

 This is fine. I fought like hell to get the bridge tests to work with the
 new API, when I knew when we were switching that it was easier to keep
 separate. I am going making the bridge reachability tests their own thing,
 and there are parts where it calls oonicli to use the
 twisted.trial.unittest API.

 So tl;dr: yes. Switch to the new API.

-- 
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/7347#comment:2>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs