[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]
Re: [tor-bugs] #3594 [Tor]: Add support for SOCKS parameters in Bridge and {Client, Server}TransportPlugin lines
#3594: Add support for SOCKS parameters in Bridge and
{Client,Server}TransportPlugin lines
---------------------------+------------------------------------------------
Reporter: asn | Owner:
Type: defect | Status: needs_revision
Priority: normal | Milestone: Tor: 0.2.4.x-final
Component: Tor | Version:
Keywords: pt tor-bridge | Parent: #7211
Points: | Actualpoints:
---------------------------+------------------------------------------------
Comment(by asn):
Replying to [comment:9 nickm]:
> Reviewing...
>
> * I think the names for tor_escape_string and string_is_key_value
should really have something to say they're only for this particular use
(socks argument parsing/encoding).
> * It makes me sad that we are proliferating ways to escape and
unescape stuff.
I agree. That's the main reason I made `tor_escape_string()` that generic.
So that we could reuse it in existing code, or at least use it in the
future the next time we need to escape something.
Seems like you prefer `tor_escape_string()` to be more #3594-specific,
which also makes sense. I'm preparing a branch that does this change.
--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/3594#comment:17>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs