[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]
Re: [tor-bugs] #10066 [EFF-HTTPS Everywhere]: Incorrect git hash used by makexpi.sh and merge-rulesets.py
#10066: Incorrect git hash used by makexpi.sh and merge-rulesets.py
----------------------------------+--------------------------
Reporter: mikeperry | Owner: zyan
Type: defect | Status: reopened
Priority: High | Milestone:
Component: EFF-HTTPS Everywhere | Version:
Severity: Normal | Resolution:
Keywords: | Actual Points:
Parent ID: | Points:
Sponsor: |
----------------------------------+--------------------------
Changes (by gk):
* status: closed => reopened
* resolution: worksforme =>
* severity: => Normal
Comment:
Replying to [comment:2 jsha]:
> I think this is working as intended. If you want to build a given tag,
e.g. 4.0.2, you run:
>
> ./makexpi.sh 4.0.2
>
> The script creates a temporary checkout directory, cds into it, checks
out the tag, and re-runs makexpi. In that context the master commit id is
correct. I tried running ./makexpi.sh 4.0.2 starting from two different
head commit ids, and got identical output.
With the new submodules this is not working anymore for us in our Gitian
environment as
1) the submodules are cloned again which we don't want during the build
step itself (all inputs should be fetched beforehand).
2) cloning actually breaks in our Linux VM due to a certificate error
(thus, even if 1) were not a problem this would still be a show-stopper
for us).
Therefore, reopening.
--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/10066#comment:5>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs