[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

Re: [tor-bugs] #17588 [GetTor]: GetTor Logging



#17588: GetTor Logging
---------------------+---------------------
 Reporter:  sukhbir  |          Owner:  ilv
     Type:  defect   |         Status:  new
 Priority:  Medium   |      Milestone:
Component:  GetTor   |        Version:
 Severity:  Normal   |     Resolution:
 Keywords:           |  Actual Points:
Parent ID:           |         Points:
  Sponsor:           |
---------------------+---------------------

Comment (by sukhbir):

 Replying to [comment:1 ilv]:

 > What about if a "request" is considered whenever we reply to an email
 (or a message, or a DM), and we make the distinction about the type of
 request i.e. between sending links, help message, mirrors?

 Do you mean individual counters for link, help, mirror etc?

 > Is this related to the number of requests mentioned above (number of
 requests)?

 Just storing the date along with each request should work. dd-mm-yyy.
 Sounds OK?

 > Yes, clearing this after a day sounds good. I established a limit to
 avoid having to process zillions of automated requests. Main reason for
 this was to prevent an overload of the service, although we process the
 request anyways, so having a blacklist might be an overkill. However, a
 good reason to have a short limit for this is that in case someone is
 making automated requests we don't get our stats ruined.

 That's true.

 > Right now after 100 requests. I changed this a while ago in order to
 make some tests, and I didn't change it back. I think 10 or less should be
 a good number.

 Where is this constant defined? Since thus number is arbitrary in any
 case, 10 sounds OK.

 > I think we have two options here:
 >
 >   1) extracting this from the log files, and then insert it into the
 database.
 >   2) storing this on the database directly when we process a request.
 >
 > I would say 2), because I think we should use the log files to help
 debugging if/when something goes wrong, not for extracting data.

 Do you think it matters if we are only reading from the log file? I am
 personally OK with both. The deciding factor here is which will take more
 time to implement? (Unless I am missing your concern with 2).

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/17588#comment:2>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs