[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]
Re: [tor-bugs] #19875 [Core Tor/Tor]: shuffle our bridges when we load them from config
#19875: shuffle our bridges when we load them from config
--------------------------+------------------------------
Reporter: arma | Owner:
Type: enhancement | Status: new
Priority: Medium | Milestone: Tor: 0.2.???
Component: Core Tor/Tor | Version:
Severity: Normal | Resolution:
Keywords: easy | Actual Points:
Parent ID: | Points:
Reviewer: | Sponsor:
--------------------------+------------------------------
Comment (by arma):
I can see having a ShuffleBridges option during testing the patch, but I
think the actual patch we merge should be much simpler -- ideally just the
one line change that I proposed long ago, assuming that works. To be
clearer, I think any user who is relying on the "one at a time, in that
order" accidental behavior of bridge lines in torrc is doing it wrong.
We would be wise to write a more explanatory comment for the function
though -- e.g. about how Tor is going to use the order of these bridges in
its state file, so shuffling will only matter for bridges that aren't
already in the state file, for example on first run.
I'm also a big fan of pastly's notion of tests -- it might take quite a
bit of testing infrastructure to test this one well.
--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/19875#comment:9>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs