[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

Re: [tor-bugs] #20564 [Metrics]: Add Jenkins configuration for running metrics-lib's unit tests and producing a .jar file

#20564: Add Jenkins configuration for running metrics-lib's unit tests and
producing a .jar file
-------------------------+--------------------------
 Reporter:  karsten      |          Owner:  hiro
     Type:  enhancement  |         Status:  assigned
 Priority:  Medium       |      Milestone:
Component:  Metrics      |        Version:
 Severity:  Normal       |     Resolution:
 Keywords:               |  Actual Points:
Parent ID:               |         Points:
 Reviewer:               |        Sponsor:
-------------------------+--------------------------

Comment (by iwakeh):

 @karsten:
 I just noticed [https://gitweb.torproject.org/metrics-
 lib.git/commit/?id=d154982e5a974bf451086241e79f9b3d9f56b2c6 this commit]
 in metrics-lib, which I think should be reverted.

 1. the addition of `unless="jenkins"` is unnecessary as the `checks` task
 is not depended on and only called directly.
 2. the addition of `clean` to `depends` in the `test` task is not needed
 and wasn't discussed.  I suggested to call `ant clean` in addition to the
 various other tasks.  So, that change is unnecessary too.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/20564#comment:31>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs